Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix substring_index crash tiflash in some case (#9137) #9140

Merged
merged 3 commits into from
Jun 13, 2024
Merged

expression: fix substring_index crash tiflash in some case (#9137) #9140

merged 3 commits into from
Jun 13, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9137

What problem does this PR solve?

Issue Number: close #9116

Problem Summary:

What is changed and how it works?

Fix tiflash crash caused by function `substring_index` in some corner cases

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix tiflash crash caused by function `substring_index` in some corner cases

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 11, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label Jun 11, 2024
windtalker
windtalker approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 11, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: solotzg, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-11 10:03:23.8471343 +0000 UTC m=+458957.900446225: ☑️ agreed by windtalker.
  • 2024-06-12 04:46:26.591654099 +0000 UTC m=+526340.644966024: ☑️ agreed by solotzg.

@wshwsh12
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3962fba into pingcap:release-7.5 Jun 13, 2024
5 checks passed
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@ti-chi-bot @wshwsh12
@ti-chi-bot @JaySon-Huang
expression: fix substring_index crash tiflash in some case (pingcap#9137
a916c26 
) (pingcap#9140)

close pingcap#9116

Fix tiflash crash caused by function `substring_index` in some corner cases

Co-authored-by: wshwsh12 <793703860@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@solotzg solotzg solotzg approved these changes

Assignees

@wshwsh12 wshwsh12

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @wshwsh12 @windtalker @solotzg