KVStore: Enhance Parallel Prehandle #9155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Lloyd-Pottiger
approved these changes
Jun 21, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
JinheLin
reviewed
Jun 21, 2024
| @@ -448,6 +448,10 @@ size_t KVStore::getOngoingPrehandleTaskCount() const | |||
| { | |||
| return std::max(0, ongoing_prehandle_task_count.load()); | |||
| } | |||
| size_t KVStore::getOngoingPrehandleSubtaskCount() const | |||
| { | |||
| return std::max(0, prehandling_trace.ongoing_prehandle_subtask_count.load()); | |||
There was a problem hiding this comment.
Is it possible for ongoing_prehandle_subtask_count to be a negative number?
There was a problem hiding this comment.
So why need std::max here?
JinheLin
approved these changes
Jun 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
| LOG_DEBUG( | ||
| log, | ||
| "Done loading all kvpairs, CF={} offset={} processed_bytes={} write_cf_offset={} region_id={} split_id={} " | ||
| "snapshot_index={}", | ||
| "snapshot_index={} elapsed_sec={} speed={}", |
There was a problem hiding this comment.
this print elapsed_sec with milliseconds, which is confusing...
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8081
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note