-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: Allow empty security config for disabling tls (#9234) #9238
security: Allow empty security config for disabling tls (#9234) #9238
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-integration-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
pingcap#9238) close pingcap#9235 security: allow empty `security.ca_path`/`security.cert_path`/`security.key_path` Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com>
This is an automated cherry-pick of #9234
What problem does this PR solve?
Issue Number: close #9235
Problem Summary:
TiFlash fails to start with following configs
What is changed and how it works?
If any of the
security.ca_path
/security.cert_path
/security.key_path
is empty, treat it as missing.And if all of the three config are not exist or empty strings, TLS is disabled in tiflash.
Check List
Tests
Side effects
Documentation
Release note