Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Fix rename come after database has been dropped (release-7.5) #9275

Merged

Conversation

JaySon-Huang
Copy link
Contributor

cherry-pick of #9274

What problem does this PR solve?

Issue Number: close #9266

Problem Summary:

In InterpreterRenameQuery, it use context.getDatabase which will throw an exception if the database instance is not exist in tiflash.

The database has been dropped in TiDB before TiFlash sync the schema diff of "create database". And the following rename table to that database (database_id=170) throw exception.

TiDB TiFlash
create table db_2.t_166;
sync create table db_2.t_166 and success
create database db_170;
rename table db_2.t_166 to db_170.t_166;
drop table db_170.t_166;
drop database db_170;
raft-log comes after database has been dropped, tiflash begin its schema sync
begin to sync create db_170 but failed sliently
begin to sync rename db_2.t_166 to db_170.t_166 but exception thrown (crash here)

What is changed and how it works?


In SchemaBuilder::applyRenamePhysicalTable it should create a local IDatabase instance with a "fake" DBInfo if can not fetch from TiKV.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix a bug that TiFlash may panic when a database is created and then dropped quickly

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 1, 2024
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang JaySon-Huang changed the title ddl: Fix rename come after database has been dropped ddl: Fix rename come after database has been dropped (release-7.5) Aug 1, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2024
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

known unstable case: #9233

[2024-08-01T02:17:52.262Z] fullstack-test2/ddl/rename_table_across_databases.test: Running
[2024-08-01T02:18:14.144Z]   File: fullstack-test2/ddl/rename_table_across_databases.test
[2024-08-01T02:18:14.144Z]   Error line: 117
[2024-08-01T02:18:14.144Z]   Error: set session tidb_isolation_read_engines='tiflash'; select * from test_new.part4 order by id;
[2024-08-01T02:18:14.144Z]   Result:

[2024-08-01T02:18:14.144Z]     ERROR 1105 (HY000) at line 1: other error for mpp stream: Code: 107, e.displayText() = DB::Exception: Cannot open file /tmp/tiflash/data/db/metadata/db_708
t_714.sql, errno: 2, strerror: No such file or directory, e.what() = DB::Exception,
[2024-08-01T02:18:14.144Z]   Expected:
[2024-08-01T02:18:14.144Z]     +----+----------+------+
[2024-08-01T02:18:14.144Z]     | id | store_id | c1   |
[2024-08-01T02:18:14.144Z]     +----+----------+------+
[2024-08-01T02:18:14.144Z]     |  1 |        1 | NULL |
[2024-08-01T02:18:14.144Z]     |  2 |        2 | NULL |
[2024-08-01T02:18:14.144Z]     |  3 |        3 | NULL |
[2024-08-01T02:18:14.144Z]     | 11 |       11 | NULL |
[2024-08-01T02:18:14.144Z]     | 16 |       16 | NULL |
[2024-08-01T02:18:14.144Z]     +----+----------+------+

@JaySon-Huang
Copy link
Contributor Author

/run-integration-test

@JaySon-Huang
Copy link
Contributor Author

/run-integration-test

Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-01 02:01:19.519621054 +0000 UTC m=+407595.799669146: ☑️ agreed by Lloyd-Pottiger.
  • 2024-08-01 03:40:48.138610204 +0000 UTC m=+413564.418658274: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 8ed9835 into pingcap:release-7.5 Aug 1, 2024
5 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_rename_come_after_db_drop_75 branch August 1, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants