Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mac build #9305

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix mac build #9305

merged 1 commit into from
Aug 9, 2024

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Aug 9, 2024

What problem does this PR solve?

Issue Number: close #9306

Problem Summary:

2024-08-09T16:38:58.501736078+08:00 /Users/pingcap/workspace/bp-tiflash-release-darwin-amd64-m7wlv-build-binaries/source/tiflash/dbms/src/Operators/AutoPassThroughHashAggContext.cpp:64:45: note: in instantiation of function template specialization 'std::make_shared<std::vector<unsigned long long>, std::vector<unsigned long>, void>' requested here
2024-08-09T16:38:58.501738228+08:00             new_block.info.selective = std::make_shared<std::vector<UInt64>>(std::move(pass_through_rows));
2024-08-09T16:38:58.501740465+08:00                                             ^
2024-08-09T16:38:58.501742711+08:00 /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/construct_at.h:35:16: note: candidate template ignored: substitution failure [with _Tp = std::vector<unsigned long long>, _Args = <std::vector<unsigned long>>]: no matching constructor for initialization of 'std::vector<unsigned long long>'
2024-08-09T16:38:58.501745103+08:00 constexpr _Tp* construct_at(_Tp* __location, _Args&& ...__args) {
2024-08-09T16:38:58.501747467+08:00                ^
2024-08-09T16:38:58.501749818+08:00 1 error generated.
2024-08-09T16:38:58.505245979+08:00 make[3]: *** [dbms/CMakeFiles/dbms.dir/src/Operators/AutoPassThroughHashAggContext.cpp.o] Error 1

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 9, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-09 10:07:26.542491307 +0000 UTC m=+605776.409590394: ☑️ agreed by JaySon-Huang.
  • 2024-08-09 13:23:04.369143274 +0000 UTC m=+617514.236242360: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit aac1dae into pingcap:master Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiflash mac build failed
3 participants