Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat serverless FAP features including shard_ver, txn ref and enc key #9434

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Sep 14, 2024

What problem does this PR solve?

Issue Number: ref #8673

Problem Summary:

Ref https://github.com/tidbcloud/tiflash-cse/pull/287.

We have to add some dummy implementations in TiFlash master, to reduce the divergence between serverless interfaces and codes.

The PR includes:

  1. In Proxy, we update ProxyFFI.h for some changes. We also introduce a serverless_extra.rs file that does nothing as a stub file.
  2. In TiFlash, we add and change some functions in FastAddPeer.cpp to support newly added interfaces. The newly add functions will always return empty(string or int). So there is little side effect.

What is changed and how it works?

Compatibility for serverless FAP features including shard_ver, txn ref and enc key

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Sep 14, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo changed the title DNM Compat serverless FAP features including shard_ver, txn ref and enc key Compat serverless FAP features including shard_ver, txn ref and enc key Sep 19, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

The changes in tiflash-proxy should be a formal commit on the raftstore-proxy branch?

@CalvinNeo
Copy link
Member Author

Generally LGTM

The changes in tiflash-proxy should be a formal commit on the raftstore-proxy branch?

Yes, Hold this PR until proxy's PR is merged

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/unhold

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 07:17:39.480877149 +0000 UTC m=+1204729.221301104: ☑️ agreed by JaySon-Huang.
  • 2024-09-20 07:35:35.194789972 +0000 UTC m=+1205804.935213895: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit d22df76 into pingcap:master Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants