Storages: Skip filtering for filter column (#9361) #9481
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9361
What problem does this PR solve?
Issue Number: close #9348, ref #9103
Problem Summary:
If Min-Max index returns RSResult::All, we will create a EMPTY filter column to make some checks on block structure happy.
tiflash/dbms/src/DataStreams/FilterTransformAction.cpp
Lines 77 to 85 in f0a4087
In LateMaterializationBlockInputStream, filter_column_stream does not execute projecting to remove filter column, and will execute filtering in
tiflash/dbms/src/Storages/DeltaMerge/LateMaterializationBlockInputStream.cpp
Lines 72 to 75 in f0a4087
This result issue #9348.
What is changed and how it works?
Skip filtering for filter column as
tiflash/dbms/src/Storages/DeltaMerge/LateMaterializationBlockInputStream.cpp
Lines 113 to 117 in f0a4087
Add add unit-test for this case.
Check List
Tests
Side effects
Documentation
Release note