vector: refine vector search #9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Lloyd-Pottiger
changed the title
JinheLin
reviewed
Dec 16, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Lloyd-Pottiger
force-pushed
the
optimize-vs
branch
from
7c8ce4c to
4222929
Compare
JinheLin
reviewed
Dec 19, 2024
JinheLin
reviewed
Dec 19, 2024
JinheLin
reviewed
Dec 19, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
|
Some small comments Lloyd-Pottiger#20 |
* Add comments Signed-off-by: JaySon-Huang <tshent@qq.com> * Refine some codes Signed-off-by: JaySon-Huang <tshent@qq.com> --------- Signed-off-by: JaySon-Huang <tshent@qq.com>
dbms/src/Storages/DeltaMerge/File/DMFileWithVectorIndexBlockInputStream.cpp
Outdated
Show resolved
Hide resolved
dbms/src/Storages/DeltaMerge/File/DMFileWithVectorIndexBlockInputStream.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
JinheLin
reviewed
Dec 20, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Lloyd-Pottiger
force-pushed
the
optimize-vs
branch
from
d6e13fc to
370657d
Compare
JinheLin
reviewed
Dec 20, 2024
JinheLin
reviewed
Dec 20, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
JinheLin
reviewed
Dec 20, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
JinheLin
reviewed
Dec 20, 2024
dbms/src/Storages/DeltaMerge/File/DMFileWithVectorIndexBlockInputStream.cpp
Outdated
Show resolved
Hide resolved
JinheLin
approved these changes
Dec 20, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
I'd like to keep the interface like this Lloyd-Pottiger#21 . This give us a picture that we organize the read by But I'm OK with the current status. Rest LGTM |
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
approved these changes
Dec 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
What is changed and how it works?
Before, we read selected vector rows from the vector index and use default to replace other rows, and then do bitmap filtering to filter out other rows.
Now, we
XXXVectorIndexReaderonly return selected rows, and only do bitmap filtering for files without the vector index.Also:
lm_skip_rowsin ScanContext.Check List
Tests
Side effects
Documentation
Release note