fix unit test

pingcap · Apr 3, 2023 · 35a7073 · 35a7073
1 parent 4ae8d27
commit 35a7073
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/cdc/sink/mysql/mysql.go b/cdc/sink/mysql/mysql.go
@@ -183,16 +183,17 @@ func NewMySQLSink(
 			"some types of DDL may fail to be executed",
 			zap.String("hostname", hostName), zap.String("port", port))
 	}
-	db, err := GetDBConnImpl(ctx, dsnStr)
+
+	isTiDB, err := CheckIsTiDB(ctx, testDB)
 	if err != nil {
 		return nil, err
 	}
+	params.isTiDB = isTiDB
 
-	isTiDB, err := CheckIsTiDB(ctx, db)
+	db, err := GetDBConnImpl(ctx, dsnStr)
 	if err != nil {
 		return nil, err
 	}
-	params.isTiDB = isTiDB
 
 	log.Info("Start mysql sink")
 

diff --git a/cdc/sink/mysql/mysql_test.go b/cdc/sink/mysql/mysql_test.go
@@ -985,6 +985,10 @@ func mockTestDBWithSQLMode(adjustSQLMode bool, sqlMode interface{}) (*sql.DB, er
 		"where character_set_name = 'gbk';").WillReturnRows(
 		sqlmock.NewRows([]string{"character_set_name"}).AddRow("gbk"),
 	)
+	mock.ExpectQuery("select tidb_version()").WillReturnError(&dmysql.MySQLError{
+		Number:  1305,
+		Message: "FUNCTION test.tidb_version does not exist",
+	})
 
 	mock.ExpectClose()
 	return db, nil

diff --git a/pkg/applier/redo_test.go b/pkg/applier/redo_test.go
@@ -20,6 +20,7 @@ import (
 	"testing"
 
 	"github.com/DATA-DOG/go-sqlmock"
+	dmysql "github.com/go-sql-driver/mysql"
 	"github.com/phayes/freeport"
 	"github.com/pingcap/tiflow/cdc/model"
 	"github.com/pingcap/tiflow/cdc/redo/common"
@@ -149,6 +150,10 @@ func TestApplyDMLs(t *testing.T) {
 				"where character_set_name = 'gbk';").WillReturnRows(
 				sqlmock.NewRows([]string{"character_set_name"}).AddRow("gbk"),
 			)
+			mock.ExpectQuery("select tidb_version()").WillReturnError(&dmysql.MySQLError{
+				Number:  1305,
+				Message: "FUNCTION test.tidb_version does not exist",
+			})
 			mock.ExpectClose()
 			return db, nil
 		}