dmctl: fix error and add test for binlog-schema delete (#8180) (#8207)

close #7373
pingcap · Feb 15, 2023 · 8923c92 · 8923c92
1 parent 992ae65
commit 8923c92
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/dm/dm/ctl/master/source_table_schema.go b/dm/dm/ctl/master/source_table_schema.go
@@ -172,7 +172,7 @@ func newSourceTableSchemaDeleteCmd() *cobra.Command {
 			database := args[1]
 			table := args[2]
 			request := &pb.OperateSchemaRequest{
-				Op:         pb.SchemaOp_SetSchema,
+				Op:         pb.SchemaOp_RemoveSchema,
 				Task:       taskName,
 				Sources:    sources,
 				Database:   database,

diff --git a/dm/tests/sequence_sharding_optimistic/run.sh b/dm/tests/sequence_sharding_optimistic/run.sh
@@ -164,6 +164,10 @@ run() {
 		"binlog-schema list -s mysql-replica-01,mysql-replica-02 sequence_sharding_optimistic sharding_seq_opt t2" \
 		"\"result\": true" 3
 
+	run_dm_ctl $WORK_DIR "127.0.0.1:$MASTER_PORT" \
+		"binlog-schema delete -s mysql-replica-01 sequence_sharding_optimistic sharding_seq_opt t2" \
+		"\"result\": true" 2
+
 	# try to set another schema, `c3` `int` -> `bigint`.
 	echo 'CREATE TABLE `t1` ( `id` bigint(20) NOT NULL, `c2` varchar(20) DEFAULT NULL, `c3` bigint(11) DEFAULT NULL, PRIMARY KEY (`id`)) ENGINE=InnoDB DEFAULT CHARSET=latin1 COLLATE=latin1_bin' >${WORK_DIR}/schema.sql
 	run_dm_ctl $WORK_DIR "127.0.0.1:$MASTER_PORT" \