log span

Signed-off-by: Neil Shen <overvenus@gmail.com>
pingcap · Mar 16, 2023 · 93f3626 · 93f3626
1 parent 2037c85
commit 93f3626
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/cdc/scheduler/internal/v3/keyspan/splitter_region_count.go b/cdc/scheduler/internal/v3/keyspan/splitter_region_count.go
@@ -50,13 +50,15 @@ func (m *regionCountSplitter) split(
 		log.Warn("schedulerv3: list regions failed, skip split span",
 			zap.String("namespace", m.changefeedID.Namespace),
 			zap.String("changefeed", m.changefeedID.ID),
+			zap.String("span", span.String()),
 			zap.Error(err))
 		return []tablepb.Span{span}
 	}
 	if len(regions) <= config.RegionThreshold || totalCaptures == 0 {
 		log.Info("schedulerv3: skip split span by region count",
 			zap.String("namespace", m.changefeedID.Namespace),
 			zap.String("changefeed", m.changefeedID.ID),
+			zap.String("span", span.String()),
 			zap.Int("totalCaptures", totalCaptures),
 			zap.Int("regionCount", len(regions)),
 			zap.Int("regionThreshold", config.RegionThreshold))
@@ -76,6 +78,7 @@ func (m *regionCountSplitter) split(
 			log.Warn("schedulerv3: get regions failed, skip split span",
 				zap.String("namespace", m.changefeedID.Namespace),
 				zap.String("changefeed", m.changefeedID.ID),
+				zap.String("span", span.String()),
 				zap.Error(err))
 			return []tablepb.Span{span}
 		}
@@ -84,6 +87,7 @@ func (m *regionCountSplitter) split(
 			log.Warn("schedulerv3: get regions failed, skip split span",
 				zap.String("namespace", m.changefeedID.Namespace),
 				zap.String("changefeed", m.changefeedID.ID),
+				zap.String("span", span.String()),
 				zap.Error(err))
 			return []tablepb.Span{span}
 		}
@@ -92,6 +96,7 @@ func (m *regionCountSplitter) split(
 			log.Warn("schedulerv3: list region out of order detected",
 				zap.String("namespace", m.changefeedID.Namespace),
 				zap.String("changefeed", m.changefeedID.ID),
+				zap.String("span", span.String()),
 				zap.Stringer("lastSpan", &spans[len(spans)-1]),
 				zap.Stringer("region", startRegion))
 			return []tablepb.Span{span}
@@ -119,6 +124,7 @@ func (m *regionCountSplitter) split(
 	log.Info("schedulerv3: split span by region count",
 		zap.String("namespace", m.changefeedID.Namespace),
 		zap.String("changefeed", m.changefeedID.ID),
+		zap.String("span", span.String()),
 		zap.Int("spans", len(spans)),
 		zap.Int("totalCaptures", totalCaptures),
 		zap.Int("regionCount", len(regions)),

diff --git a/cdc/scheduler/internal/v3/keyspan/splitter_write.go b/cdc/scheduler/internal/v3/keyspan/splitter_write.go
@@ -52,20 +52,23 @@ func (m *writeSplitter) split(
 		log.Warn("schedulerv3: scan regions failed, skip split span",
 			zap.String("namespace", m.changefeedID.Namespace),
 			zap.String("changefeed", m.changefeedID.ID),
+			zap.String("span", span.String()),
 			zap.Error(err))
 		return nil
 	}
 	if totalCaptures <= 1 {
 		log.Warn("schedulerv3: only one capture, skip split span",
 			zap.String("namespace", m.changefeedID.Namespace),
 			zap.String("changefeed", m.changefeedID.ID),
+			zap.String("span", span.String()),
 			zap.Error(err))
 		return []tablepb.Span{span}
 	}
 	info := splitRegionsByWrittenKeys(span.TableID, regions, config.WriteKeyThreshold, totalCaptures)
 	log.Info("schedulerv3: split span by written keys",
 		zap.String("namespace", m.changefeedID.Namespace),
 		zap.String("changefeed", m.changefeedID.ID),
+		zap.String("span", span.String()),
 		zap.Ints("counts", info.Counts),
 		zap.Ints("weights", info.Weights),
 		zap.Int("spans", len(info.Spans)),