Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: handle the query in metadata from binlog #11743

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dm: handle the query in metadata from binlog #11743

wants to merge 2 commits into from

Conversation

joccau
Copy link
Member

@joccau joccau commented Nov 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11735

What is changed and how it works?

Handle the new format of binlog metadata from mariadb to read the binlog position.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?

Not.

Do you need to update user documentation, design documentation or monitoring documentation?

Not.

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@joccau
handle the query in metadata from binlog
8a7dc8e 
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. labels Nov 13, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-bot
Copy link

sre-bot commented Nov 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Nov 13, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1605%. Comparing base (b2a4f9a) to head (1020abf).

Additional details and impacted files
Components Coverage Δ
cdc 59.5962% <ø> (+0.0206%) ⬆️
dm 50.0327% <100.0000%> (-0.0039%) ⬇️
engine 53.2449% <ø> (+0.0056%) ⬆️
Flag Coverage Δ
unit 55.1605% <100.0000%> (+0.0094%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11743        +/-   ##
================================================
+ Coverage   55.1510%   55.1605%   +0.0094%     
================================================
  Files          1002       1002                
  Lines        137399     137399                
================================================
+ Hits          75777      75790        +13     
+ Misses        56074      56063        -11     
+ Partials       5548       5546         -2

@joccau
add unit test
1020abf 
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2024
@joccau joccau changed the title handle the query in metadata from binlog[wip] handle the query in metadata from binlog Nov 14, 2024
@joccau joccau changed the title handle the query in metadata from binlog dm: handle the query in metadata from binlog Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metadata error with MariaDB 11.4
2 participants
@joccau @sre-bot