Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple worker write for same upstream #3737

Closed
GMHDBJD opened this issue Dec 6, 2021 · 3 comments · Fixed by #4035
Closed

multiple worker write for same upstream #3737

GMHDBJD opened this issue Dec 6, 2021 · 3 comments · Fixed by #4035
Assignees
@Ehco1996
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. area/dm Issues or PRs related to DM. severity/major type/bug The issue is confirmed as a bug.

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Dec 6, 2021

What did you do?

chaos test: pod kill dm

What did you expect to see?

no error log in dm-worker.log

What did you see instead?

write conflict: insert xxxx

Versions of the cluster

DM version (run dmctl -V or dm-worker -V or dm-master -V):

master

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
@GMHDBJD GMHDBJD added type/bug The issue is confirmed as a bug. area/dm Issues or PRs related to DM. labels Dec 6, 2021
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 6, 2021 •
edited
Loading

The log shows that after chaos kill worker1, worker1 still wait for all jobs flushed, while worker2 bound to source1 immediately and then write same data from source1, then cause write conflict.

@GMHDBJD GMHDBJD mentioned this issue Dec 6, 2021
Closed
@lance6716
Copy link
Contributor

lance6716 commented Dec 7, 2021 •
edited
Loading

seems a correct exit logic is very complex... we should use a context.WithDelayedCancel(ctx, delayTime, immediateCancelCh)

@XuJianxu XuJianxu assigned GMHDBJD and D3Hunter and unassigned GMHDBJD Dec 9, 2021
@lance6716
Copy link
Contributor

lance6716 commented Dec 16, 2021 •
edited
Loading

/assign @Ehco1996

also please take a look at if we can implement context.WithDelayedCancel(ctx, delayTime, immediateCancelCh)

@Ehco1996 Ehco1996 mentioned this issue Dec 23, 2021
Merged
@jebter jebter added the affects-5.4 This bug affects the 5.4.x(LTS) versions. label Jan 18, 2022
ti-chi-bot pushed a commit that referenced this issue Feb 16, 2022
@Ehco1996
unit(dm): add Kill func for unit (#4035)
e7b0aae 
close #3737
This was referenced Feb 16, 2022
Closed
Closed
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this issue Feb 16, 2022
@Ehco1996 @zhaoxinyu
unit(dm): add Kill func for unit (pingcap#4035)
2936f38 
close pingcap#3737
@GMHDBJD GMHDBJD mentioned this issue Nov 21, 2022
Closed
@lance6716 lance6716 mentioned this issue Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ehco1996 Ehco1996

Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. area/dm Issues or PRs related to DM. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unit(dm): add Kill func for unit
6 participants
@lance6716 @D3Hunter @jebter @XuJianxu @Ehco1996 @GMHDBJD