Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM: Support MySQL 8.0 compressed binlog #6381

Closed
dveeden opened this issue Jul 20, 2022 · 3 comments · Fixed by #8373
Closed

DM: Support MySQL 8.0 compressed binlog #6381

dveeden opened this issue Jul 20, 2022 · 3 comments · Fixed by #8373
Labels
area/dm Issues or PRs related to DM. type/feature Issues about a new feature

Comments

@dveeden
Copy link
Contributor

dveeden commented Jul 20, 2022

Is your feature request related to a problem?

// SupportedVersion defines the MySQL/MariaDB version that DM/syncer supports
// * 5.6.0 <= MySQL Version < 8.0.0.
var SupportedVersion = map[string]struct {
Min MySQLVersion
Max MySQLVersion
}{
"mysql": {
MySQLVersion{5, 6, 0},
MySQLVersion{8, 0, 0},
},
}

When creating a task with a MySQL 8.0 source:

			{
				"id": 0,
				"name": "mysql_version",
				"desc": "check whether mysql version is satisfied",
				"state": "warn",
				"errors": [
					{
						"severity": "warn",
						"short_error": "version suggested less than 8.0.0 but got 8.0.29"
					}
				],
				"extra": "address of db instance - 127.0.0.1:39135"
			}

Describe the feature you'd like

Support MySQL 8.0

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response

@dveeden dveeden added the type/feature Issues about a new feature label Jul 20, 2022
@dveeden
Copy link
Contributor Author

dveeden commented Jul 20, 2022

/area dm

@ti-chi-bot ti-chi-bot added the area/dm Issues or PRs related to DM. label Jul 20, 2022
@lance6716
Copy link
Contributor

There is a MySQL 8.0 features that will break the replication #5141 . And we have not fully utilized new features like https://dev.mysql.com/worklog/task/?id=4618 . A long way to go!

@dveeden
Copy link
Contributor Author

dveeden commented Jul 21, 2022

There is a MySQL 8.0 features that will break the replication #5141 . And we have not fully utilized new features like https://dev.mysql.com/worklog/task/?id=4618 . A long way to go!

Could we convert this check from a version based check to a feature based one? In this case to check if binlog compression is enabled instead of checking if the server is running MySQL 8.0.0 or newer?

Also, shouldn't this check be (also) done when defining the source instead of only when defining the task?

ti-chi-bot bot pushed a commit that referenced this issue Jun 21, 2023
@GMHDBJD GMHDBJD changed the title DM: Support MySQL 8.0 DM: Support MySQL 8.0 compressed binlog Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. type/feature Issues about a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants