Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up after fixing Nondeterministic DDL #6628

Closed
lance6716 opened this issue Aug 5, 2022 · 0 comments · Fixed by #7036
Closed

follow-up after fixing Nondeterministic DDL #6628

lance6716 opened this issue Aug 5, 2022 · 0 comments · Fixed by #7036
Assignees
Labels
area/dm Issues or PRs related to DM. severity/minor type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

What did you do?

  1. modification to job.ddls should be as late as possible

    tiflow/dm/syncer/syncer.go

    Lines 1332 to 1336 in 5a0452d

    // set timezone
    if ddlJob.timezone != "" {
    s.timezoneLastTime = ddlJob.timezone
    setTimezoneSQL := fmt.Sprintf("SET SESSION TIME_ZONE = '%s'", ddlJob.timezone)
    ddlJob.ddls = append([]string{setTimezoneSQL}, ddlJob.ddls...)

to avoid interfering the logic between modification and using. Like

if len(ddlJob.ddls) == 0 {

  1. there're too many warnings in log, we know in most of time there's no timezone information in status vars, so should not raise warning so frequently
    ddl.logger.Warn("found error when get timezone from binlog status_vars", zap.Error(err))

What did you expect to see?

No response

What did you see instead?

No response

Versions of the cluster

master

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants