Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDC support TTL table #7997

Closed
Tracked by #39262
lcwangchao opened this issue Dec 29, 2022 · 2 comments · Fixed by #7998
Closed
Tracked by #39262

CDC support TTL table #7997

lcwangchao opened this issue Dec 29, 2022 · 2 comments · Fixed by #7998
Labels
type/feature Issues about a new feature

Comments

@lcwangchao
Copy link
Contributor

Is your feature request related to a problem?

CDC should support TTL table

Describe the feature you'd like

When a table is a TTL table in upstream, the downstream should turn off its TTL_ENABLE option to OFF

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@lcwangchao lcwangchao added the type/feature Issues about a new feature label Dec 29, 2022
@lcwangchao lcwangchao mentioned this issue Dec 29, 2022
Merged
@nongfushanquan
Copy link
Contributor

why should the downstream turn off the ttl_enable option ?

@lcwangchao
Copy link
Contributor Author

why should the downstream turn off the ttl_enable option ?

It is a discussed conclusion with @SunRunAway . I think the main reason is the upstream will also sync delete operations to the downstream so we do not need to open TTL in the downstream. Another reason is that if TTL_ENABLE is on in the downstream cluster, there can be true that a row is deleted in the downstream but still exists in the upstream because of the downstream's TTL job. To avoid some confusing phenomenon, it's better to turn it off

ti-chi-bot pushed a commit that referenced this issue Feb 20, 2023
@lcwangchao
sink(ticdc): support TTL table for cdc sink (#7998)
3d5cbb4 
close #7997
@lcwangchao lcwangchao mentioned this issue Feb 20, 2023
Closed
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature Issues about a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sink(ticdc): support TTL table for cdc sink lcwangchao/tiflow
2 participants
@lcwangchao @nongfushanquan