Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let TiCDC replicate table without primary/unique key #994

Closed
IANTHEREAL opened this issue Oct 15, 2020 · 0 comments · Fixed by #1005
Closed

Let TiCDC replicate table without primary/unique key #994

IANTHEREAL opened this issue Oct 15, 2020 · 0 comments · Fixed by #1005
Assignees
@amyangfei
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. subject/new-feature Denotes an issue or pull request adding a new feature.
Milestone
v4.0.8

Comments

@IANTHEREAL
Copy link
Collaborator

IANTHEREAL commented Oct 15, 2020 •
edited
Loading

Feature Request

Is your feature request related to a problem? Please describe:

Restrict as described in the TiCDC document

TiCDC couldn't replicate the table without primary key/unique, the reason was that TiCDC could not output the row data of the deleted changelog of these tables, which caused the downstream unable to restore the delete operation.
But now TiCDC supports output row data and tidb-binlog can replicate these tables.
Because the correctness of these tables cannot be guaranteed, there are two options

  1. TiCDC removes restrictions, supports replicating these tables, and is not responsible for the correctness of these tables replication
  2. TiCDC reserves restrictions. It is recommended that users add auto-random in tidb to these tables in the replicate scheme(TiDB <-> MySQL/TiDB)
@amyangfei amyangfei added the status/need-discussion Issue that needs to be discussed to confirm priority, milestone, plan and task breakdown. label Oct 15, 2020
@IANTHEREAL IANTHEREAL added feature request help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed feature request status/need-discussion Issue that needs to be discussed to confirm priority, milestone, plan and task breakdown. labels Oct 16, 2020
@scsldb scsldb added subject/new-feature Denotes an issue or pull request adding a new feature. feature/accepted and removed feature request labels Oct 16, 2020
@amyangfei amyangfei self-assigned this Oct 16, 2020
@amyangfei amyangfei added this to the v4.0.8 milestone Oct 19, 2020
@amyangfei amyangfei mentioned this issue Oct 19, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amyangfei amyangfei

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Milestone
v4.0.8
Development

Successfully merging a pull request may close this issue.

*: support to replicate tables without explicit row id amyangfei/tiflow
3 participants
@amyangfei @scsldb @IANTHEREAL