*: support to replicate tables without explicit row id #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
the
needs-cherry-pick-release-4.0
|
/run-all-tests |
|
LGTM |
|
/run-all-tests |
zier-one
approved these changes
Oct 20, 2020
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Oct 20, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/run-integraion-tests |
2 similar comments
|
/run-integraion-tests |
|
/run-integraion-tests |
|
/merge |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
===========================================
Coverage 32.2260% 32.2260%
===========================================
Files 101 101
Lines 11680 11680
===========================================
Hits 3764 3764
Misses 7503 7503
Partials 413 413 |
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Oct 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close https://github.com/pingcap/ticdc/issues/994
What is changed and how it works?
force-replicateoption in changefeed config, if bothenable-old-valueandforce-replicatearetrue, TiCDC will replicate tables without any explicit row id.Clonefunction ofschemaSnapshot.forceReplicateoption inIsEligiblefuncion of aTableInfoto control the eligible logic.Check List
Tests
Code changes
Related changes
Release note