Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink (ticdc): add ddl encoder for simple protocol #10022

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Nov 7, 2023

What problem does this PR solve?

Issue Number: ref #9898 close #9901

What is changed and how it works?

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2023
@asddongmen asddongmen changed the title [WIP]sink (ticdc): add ddl encoder for simple protocol sink (ticdc): add ddl encoder for simple protocol Nov 9, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 9, 2023
@asddongmen asddongmen added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Nov 9, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 9, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 13, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 13, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-13 03:18:14.65602274 +0000 UTC m=+4046292.243132884: ☑️ agreed by 3AceShowHand.
  • 2023-11-13 09:12:52.644942029 +0000 UTC m=+4067570.232052173: ☑️ agreed by sdojjy.

@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit fa64375 into pingcap:master Nov 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encoding & decoding DDL event
3 participants