Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config(ticdc): change case-sensitive default value (#10049) #10076

Merged
merged 2 commits into from
Dec 4, 2023
Merged

config(ticdc): change case-sensitive default value (#10049) #10076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b44305b
This is an automated cherry-pick of #10049
sdojjy Nov 10, 2023
02e5855
Merge remote-tracking branch 'upstream/release-7.1' into cherry-pick-…
sdojjy Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cdc/api/v2/model_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
// note: this is api published default value, not change it
var defaultAPIConfig = &ReplicaConfig{
MemoryQuota: config.DefaultChangefeedMemoryQuota,
CaseSensitive: true,
CaseSensitive: false,
EnableOldValue: true,
CheckGCSafePoint: true,
EnableSyncPoint: false,
Expand Down
2 changes: 1 addition & 1 deletion cdc/model/changefeed_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func TestVerifyAndComplete(t *testing.T) {
StartTs: 417257993615179777,
Config: &config.ReplicaConfig{
MemoryQuota: 1073741824,
CaseSensitive: true,
CaseSensitive: false,
EnableOldValue: true,
CheckGCSafePoint: true,
SyncPointInterval: time.Minute * 10,
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/replica_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const (

var defaultReplicaConfig = &ReplicaConfig{
MemoryQuota: DefaultChangefeedMemoryQuota,
CaseSensitive: true,
CaseSensitive: false,
EnableOldValue: true,
CheckGCSafePoint: true,
EnableSyncPoint: false,
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/api_v2/cases.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ var customReplicaConfig = &ReplicaConfig{
// defaultReplicaConfig check if the default values is changed
var defaultReplicaConfig = &ReplicaConfig{
MemoryQuota: 1024 * 1024 * 1024,
CaseSensitive: true,
CaseSensitive: false,
EnableOldValue: true,
CheckGCSafePoint: true,
EnableSyncPoint: false,
Expand Down
4 changes: 2 additions & 2 deletions tests/integration_tests/cli/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function run() {

# Update changefeed failed because changefeed is running
cat - >"$WORK_DIR/changefeed.toml" <<EOF
case-sensitive = false
case-sensitive = true
[scheduler]
enable-table-across-nodes = true
EOF
Expand All @@ -89,7 +89,7 @@ EOF
# Update changefeed
run_cdc_cli changefeed update --pd=$pd_addr --config="$WORK_DIR/changefeed.toml" --no-confirm --changefeed-id $uuid
changefeed_info=$(curl -s -X GET "http://127.0.0.1:8300/api/v2/changefeeds/$uuid/meta_info" 2>&1)
if [[ ! $changefeed_info == *"\"case_sensitive\":false"* ]]; then
if [[ ! $changefeed_info == *"\"case_sensitive\":true"* ]]; then
echo "[$(date)] <<<<< changefeed info is not updated as expected ${changefeed_info} >>>>>"
exit 1
fi
Expand Down
Loading