-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(cdc): avoid sinking redundant events in some rare cases with redo enabled #10096
Merged
ti-chi-bot
merged 5 commits into
pingcap:release-6.5-20230923-v6.5.5
from
hicqu:release-6.5-20230923-v6.5.5-10065
Nov 14, 2023
Merged
sink(cdc): avoid sinking redundant events in some rare cases with redo enabled #10096
ti-chi-bot
merged 5 commits into
pingcap:release-6.5-20230923-v6.5.5
from
hicqu:release-6.5-20230923-v6.5.5-10065
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/release-note-label-needed
Indicates that a PR should not merge because it's missing one of the release note labels.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 14, 2023
hicqu
changed the title
Release 6.5 20230923 v6.5.5 10065
sink(cdc): avoid sinking redundant events in some rare cases with redo enabled
Nov 14, 2023
ti-chi-bot
bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
and removed
do-not-merge/release-note-label-needed
Indicates that a PR should not merge because it's missing one of the release note labels.
labels
Nov 14, 2023
sdojjy
approved these changes
Nov 14, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Nov 14, 2023
CharlesCheung96
approved these changes
Nov 14, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
hicqu
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Nov 14, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Nov 14, 2023
/test verify |
ti-chi-bot
bot
merged commit Nov 14, 2023
8e71949
into
pingcap:release-6.5-20230923-v6.5.5
10 checks passed
hicqu
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10065 .
What is changed and how it works?
Let's focus on file
cdc/processor/sinkmanager/table_sink_worker.go
. #10065 panics iffetchFromCache
returnsdrained=false
;for advancer.hasEnoughMem() && !task.isCanceled()
is broken immediately;After that, the variable
lastPos
can be less thanlowerBound.Prev()
, which is not expected.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note