Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api(ticdc): support create simple protocol changefeed #10116

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Nov 20, 2023

What problem does this PR solve?

Issue Number: ref #9898 close #10108

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 20, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 24, 2023
@3AceShowHand
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 03:55:07.468879035 +0000 UTC m=+549336.134105222: ☑️ agreed by 3AceShowHand.
  • 2023-11-27 03:06:15.558760703 +0000 UTC m=+805604.223986898: ☑️ agreed by CharlesCheung96.

Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96, nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/test cdc-integration-storage-test

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/test cdc-integration-storage-test

@asddongmen
Copy link
Contributor Author

/retest

1 similar comment
@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/test all

@3AceShowHand
Copy link
Contributor

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor

/retest

1 similar comment
@asddongmen
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 13499f4 into pingcap:master Nov 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support configure new protocol
5 participants