-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): cleanup expired files by day for storage sink (#10097) #10161
Merged
ti-chi-bot
merged 3 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-10097-to-release-6.5
Nov 27, 2023
Merged
sink(ticdc): cleanup expired files by day for storage sink (#10097) #10161
ti-chi-bot
merged 3 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-10097-to-release-6.5
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
labels
Nov 26, 2023
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Nov 26, 2023
CharlesCheung96
force-pushed
the
cherry-pick-10097-to-release-6.5
branch
from
November 26, 2023 15:29
87c7482
to
c3a7cda
Compare
CharlesCheung96
approved these changes
Nov 26, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CharlesCheung96
force-pushed
the
cherry-pick-10097-to-release-6.5
branch
from
November 26, 2023 15:42
c3a7cda
to
d3931e8
Compare
CharlesCheung96
force-pushed
the
cherry-pick-10097-to-release-6.5
branch
from
November 26, 2023 15:56
d3931e8
to
b69e664
Compare
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10097
What problem does this PR solve?
Issue Number: close #10109
What is changed and how it works?
Add two parameters to control the cleaning behavior of expired files, for example:
file-expiration-days
is configured, then by default cdc will clean files at 2 a.m. each day.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note