Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: fixes minor bugs #10168 and #10169 #10170

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Nov 28, 2023

What problem does this PR solve?

Issue Number: close #10168
Issue Number: close #10169
Issue Number: close #10164

What is changed and how it works?

  • Limit concurrency for scaning regions;
  • Increase sink task range from 5s to 30m.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Nov 28, 2023

/retest

1 similar comment
@hicqu
Copy link
Contributor Author

hicqu commented Nov 29, 2023

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 29, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 29, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 29, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-29 08:42:23.599097026 +0000 UTC m=+998572.264323208: ☑️ agreed by sdojjy.
  • 2023-11-29 12:10:28.944881839 +0000 UTC m=+1011057.610108034: ☑️ agreed by asddongmen.

@hicqu
Copy link
Contributor Author

hicqu commented Nov 29, 2023

/retest

2 similar comments
@hicqu
Copy link
Contributor Author

hicqu commented Nov 29, 2023

/retest

@hicqu
Copy link
Contributor Author

hicqu commented Nov 29, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit eb96b96 into pingcap:master Nov 29, 2023
14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10189.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 29, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10190.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 29, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10191.

@hicqu hicqu deleted the cdc-minor-fixes branch November 29, 2023 13:30
hicqu added a commit to hicqu/ticdc that referenced this pull request Nov 29, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to hicqu/ticdc that referenced this pull request Nov 29, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Nov 30, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to hicqu/ticdc that referenced this pull request Dec 2, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to hicqu/ticdc that referenced this pull request Dec 2, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 4, 2023
close pingcap#10168

Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 4, 2023
hicqu added a commit to hicqu/ticdc that referenced this pull request Dec 5, 2023
hicqu added a commit that referenced this pull request Dec 5, 2023
* cdc: fixes minor bugs #10168 and #10169 (#10170)
* puller(cdc): debug frontier (#10202)
* kv-client(cdc): correct conditions of canceling grpc streams  (#10237)

Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 7, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants