Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: fixes minor bugs #10168 and #10169 (#10170) #10189

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cdc/kv/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ const (
regionScheduleReload = false

resolveLockMinInterval = 10 * time.Second

scanRegionsConcurrency = 1024
)

// time interval to force kv client to terminate gRPC stream and reconnect
Expand Down Expand Up @@ -432,6 +434,8 @@ func (s *eventFeedSession) eventFeed(ctx context.Context) error {
g.Go(func() error { return s.logSlowRegions(ctx) })

g.Go(func() error {
g, ctx := errgroup.WithContext(ctx)
g.SetLimit(scanRegionsConcurrency)
for {
select {
case <-ctx.Done():
Expand Down
4 changes: 2 additions & 2 deletions cdc/processor/sinkmanager/tasks.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ var (
maxUpdateIntervalSize = defaultMaxUpdateIntervalSize

// Sink manager schedules table tasks based on lag. Limit the max task range
// can be helpful to reduce changefeed latency.
maxTaskRange = 5 * time.Second
// can be helpful to reduce changefeed latency for large initial data.
maxTaskRange = 30 * time.Minute
)

// Used to record the progress of the table.
Expand Down
Loading