Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoder (ticdc): simple protocol send bootstrap event periodically #10366

Merged
merged 23 commits into from
Jan 4, 2024
Merged

encoder (ticdc): simple protocol send bootstrap event periodically #10366

merged 23 commits into from
Jan 4, 2024

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #9898

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 27, 2023
@asddongmen asddongmen marked this pull request as draft December 27, 2023 02:29
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 27, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 27, 2023
@asddongmen asddongmen marked this pull request as ready for review December 28, 2023 04:14
@asddongmen asddongmen changed the title [WIP] encoder (ticdc): simple protocol send bootstrap event periodically encoder (ticdc): simple protocol send bootstrap event periodically Dec 28, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 28, 2023
@asddongmen asddongmen self-assigned this Dec 28, 2023
@asddongmen
Copy link
Contributor Author

/test all

@asddongmen
Copy link
Contributor Author

/retest

@asddongmen asddongmen force-pushed the simple_periodically_send_bootstrap_event branch from f7c704b to 9fae031 Compare January 2, 2024 02:16
@3AceShowHand
Copy link
Contributor

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-03 08:37:10.710218031 +0000 UTC m=+2246121.747444943: ☑️ agreed by 3AceShowHand.
  • 2024-01-04 06:55:44.132256626 +0000 UTC m=+2326435.169483553: ☑️ agreed by sdojjy.

@asddongmen @sdojjy
Update pkg/sink/codec/bootstraper.go
50a21d6 
Co-authored-by: Jianyuan Jiang <sdojjy@qq.com>
@ti-chi-bot ti-chi-bot bot added the affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. label Jan 4, 2024
@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit d060a7d into pingcap:master Jan 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@sdojjy sdojjy sdojjy approved these changes

Assignees

@asddongmen asddongmen

Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asddongmen @3AceShowHand @sdojjy