Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple (ticdc): add bootstrap sending function configuration #10476

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jan 15, 2024

What problem does this PR solve?

Issue Number: ref #9898

What is changed and how it works?

Bootstrap message is sent by the following principles:

  • For each table, before sending the first DML message, send the corresponding Bootstrap message.
  • For each table, once sending N messages, send one bootstrap message periodically. The messages number N can be configured by sink.send-bootstrap-in-msg-count.
  • For each table, if no bootstrap message is sent in the last M seconds, send one bootstrap message. The interval M can be configured by sink.send-bootstrap-interval-in-sec.
  • If a table has not received any new DML messages for 30 minutes, it will be considered inactive. We will stop sending Bootstrap events for this table until a new DML event for the table occurs.
  • Bootstrap messages are dispatched to the all partition by default. This behavior can be controlled by sink.send-bootstrap-to-all-partition, if it is set to false, Bootstrap messages will be sent to the first partition.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 15, 2024
@asddongmen asddongmen self-assigned this Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Merging #10476 (de0dd19) into master (c8ea7d0) will decrease coverage by 0.0903%.
Report is 5 commits behind head on master.
The diff coverage is 76.4705%.

Additional details and impacted files
Components Coverage Δ
cdc 61.6467% <76.4705%> (-0.1731%) ⬇️
dm 51.2275% <ø> (+0.0060%) ⬆️
engine 63.4070% <ø> (+0.0070%) ⬆️
Flag Coverage Δ
unit 57.4081% <76.4705%> (-0.0903%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10476        +/-   ##
================================================
- Coverage   57.4983%   57.4081%   -0.0903%     
================================================
  Files           849        848         -1     
  Lines        126094     125815       -279     
================================================
- Hits          72502      72228       -274     
+ Misses        48181      48177         -4     
+ Partials       5411       5410         -1     

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 18, 2024
cdc/api/v2/model.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-18 08:06:12.631141434 +0000 UTC m=+429614.195439140: ☑️ agreed by sdojjy.
  • 2024-01-19 06:03:46.993618612 +0000 UTC m=+508668.557916328: ☑️ agreed by 3AceShowHand.

@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit d4ed295 into pingcap:master Jan 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants