-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv (ticdc): fix kvClient reconnection downhill loop #10559
kv (ticdc): fix kvClient reconnection downhill loop #10559
Conversation
/test verify |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10559 +/- ##
================================================
+ Coverage 57.4947% 57.5745% +0.0797%
================================================
Files 848 848
Lines 126095 125889 -206
================================================
- Hits 72498 72480 -18
+ Misses 48136 47982 -154
+ Partials 5461 5427 -34 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, hicqu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
c48fc20
to
19612fb
Compare
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #10584
What is changed and how it works?
eventFeedStream
struct to identify a stream and prevent it from being deleted unexpectedly.eventFeedStream
to prevent the stream from being canceled unexpectedly.s.deleteStream
to only once to prevent the stream from being deleted unexpectedly.Check List
Tests
time.sleep(5 * time.second)
before callings.deleteStream
in both unfixed and fixed version of code.unfixed cdc:
fixed cdc:
From the above graphs, it is evident that in the unfixed CDC, the lag of resolvedTs can exceed 12 minutes when a TiKV node is restarted. However, in the fixed CDC, the increase in resolvedTs is limited to a maximum of 35 seconds. This demonstrates the effectiveness of the fix.
Moreover, when the hard-coded
time.sleep(5 * time.second)
is removed and the fixed version of CDC is tested again, the lag becomes even smaller:Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note