Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barrier(ticdc): fix wrong barrier ts under frequent ddl scenario (#10669) #10726

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10669

What problem does this PR solve?

Issue Number: close #10668

What is changed and how it works?

The problem detail is described in #10668.

The same physical table may have multiple related ddl events when calculating barrier.
Previous, we choose the commitTs of the last ddl met as the barrierTs for the table.
This may cause the barrierTs of some tables advanced more than expected.

In this pr, we changed to choose the min commitTs of all ddls related to the same physical table as the barrierTs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix wrong barrier ts under frequent ddl scenario.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Mar 6, 2024
@lidezhu
Copy link
Collaborator

lidezhu commented Mar 6, 2024

/test pull-cdc-integration-storage-test

Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

@lidezhu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run all jobs.

In response to this:

/test pull-cdc-integration-storage-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lidezhu
Copy link
Collaborator

lidezhu commented Mar 6, 2024

/test cdc-integration-storage-test

Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 7, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 12, 2024
@lidezhu
Copy link
Collaborator

lidezhu commented Mar 12, 2024

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot merged commit 9c3d540 into pingcap:release-7.1 Mar 12, 2024
12 checks passed
@lidezhu lidezhu deleted the cherry-pick-10669-to-release-7.1 branch March 12, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants