Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix for ErrSnapshotSchemaNotFound and ErrSchemaStorageGCed (#1069) #1114

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Temporary fix for ErrSnapshotSchemaNotFound and ErrSchemaStorageGCed (#1069) #1114

merged 1 commit into from
Nov 24, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1069 to release-4.0

What problem does this PR solve?

  • ErrSnapshotSchemaNotFound or ErrSchemaStorageGCed after table migrations.
  • Some of other potential problems caused by table puller starting from a startTs that is too early.

What is changed and how it works?

  • Fixed bug in the handling of table moves.
  • Mitigated other some situations by resetting startTs of a puller to the latest valid global checkpointTS.
  • Mitigated other some situations by delaying SchemaStorage GC by 20 minutes (in case checkpointTS advanced unexpectedly when puller is starting).
    Note: The last two are ad-hoc temporary fixes, and the problems should be identified exhaustively before making other plans for fixing.

Check List

Tests

  • Integration test
  • Manual test

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@liuzix @ti-srebot
cherry pick pingcap#1069 to release-4.0
7125054 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 24, 2020
Merged
@ti-srebot ti-srebot added type/bugfix This PR fixes a bug. component/replica-model Replication model component. component/scheduler TiCDC inner scheduler component. status/ptal Could you please take a look? type/4.0-cherry-pick labels Nov 24, 2020
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 24, 2020
@liuzix
Copy link
Contributor

liuzix commented Nov 24, 2020

/run-all-tests

@zier-one
Copy link
Contributor

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2020
@zier-one
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit b181f9d into pingcap:release-4.0 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei Awaiting requested review from amyangfei

@zier-one zier-one Awaiting requested review from zier-one

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@liuzix liuzix

Labels
component/replica-model Replication model component. component/scheduler TiCDC inner scheduler component. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @liuzix @zier-one