Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql(ticdc): do not check downstream ddl job status when create table #11520

Closed
wants to merge 3 commits into from
Closed

mysql(ticdc): do not check downstream ddl job status when create table #11520

wants to merge 3 commits into from

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Aug 23, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11521

What is changed and how it works?

  • do not check async ddl status for the create table ddl
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 23, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from 3aceshowhand, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 23, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 23, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 57.4405%. Comparing base (73fe3e4) to head (e2fbad1).
Report is 4 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.1785% <62.9629%> (-0.0237%) ⬇️
dm 51.0172% <ø> (-0.0323%) ⬇️
engine 63.3879% <ø> (-0.0212%) ⬇️
Flag Coverage Δ
unit 57.4405% <62.9629%> (-0.0262%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11520        +/-   ##
================================================
- Coverage   57.4667%   57.4405%   -0.0262%     
================================================
  Files           851        851                
  Lines        126421     126442        +21     
================================================
- Hits          72650      72629        -21     
- Misses        48370      48402        +32     
- Partials       5401       5411        +10

sdojjy
sdojjy reviewed Aug 26, 2024
View reviewed changes
cdc/sink/ddlsink/mysql/async_ddl.go
@@ -98,6 +98,12 @@ func (m *DDLSink) waitAsynExecDone(ctx context.Context, ddl *model.DDLEvent) {
return
}

switch ddl.Type {
case timodel.ActionCreateTable, timodel.ActionCreateTables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about other DDLs?

CharlesCheung96
CharlesCheung96 reviewed Aug 28, 2024
View reviewed changes
cdc/sink/ddlsink/mysql/async_ddl.go
@@ -29,7 +29,7 @@ import (
var checkRunningAddIndexSQL = `
SELECT JOB_ID, JOB_TYPE, SCHEMA_STATE, SCHEMA_ID, TABLE_ID, STATE, QUERY
FROM information_schema.ddl_jobs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use ADMIN SHOW DDL JOBS here is a better choice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy left review comments

@CharlesCheung96 CharlesCheung96 CharlesCheung96 left review comments

@asddongmen asddongmen Awaiting requested review from asddongmen

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create table ddl executed too slow when using tidb as the downstream sink
3 participants
@3AceShowHand @sdojjy @CharlesCheung96