Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd(ticdc): Export All cdc Subcommands #11677

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

wlwilliamx
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11676

What is changed and how it works?

Export all cdc subcommands for the new arch of ticdc to use.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 22, 2024
@asddongmen
Copy link
Contributor

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 08:32:35.400887652 +0000 UTC m=+339956.097678259: ☑️ agreed by asddongmen.
  • 2024-10-22 09:32:59.336618686 +0000 UTC m=+343580.033409309: ☑️ agreed by lidezhu.

@wlwilliamx
Copy link
Contributor Author

/retest

1 similar comment
@wlwilliamx
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.1621%. Comparing base (60e2bfa) to head (295e21e).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6419% <0.0000%> (-0.0018%) ⬇️
dm 50.0596% <ø> (+0.0192%) ⬆️
engine 53.2279% <ø> (-0.0396%) ⬇️
Flag Coverage Δ
unit 55.1621% <0.0000%> (+0.0013%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11677        +/-   ##
================================================
+ Coverage   55.1607%   55.1621%   +0.0013%     
================================================
  Files          1001       1001                
  Lines        136472     136474         +2     
================================================
+ Hits          75279      75282         +3     
+ Misses        55685      55681         -4     
- Partials       5508       5511         +3     

@wlwilliamx
Copy link
Contributor Author

/retest

3 similar comments
@wlwilliamx
Copy link
Contributor Author

/retest

@wlwilliamx
Copy link
Contributor Author

/retest

@wlwilliamx
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit dd2d54a into pingcap:master Oct 23, 2024
28 checks passed
@wlwilliamx wlwilliamx deleted the refactor/export-cmd-package branch October 23, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ticdc: Export All cdc Subcommands
3 participants