Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(ticdc): add integration test for safe mode #11678

Merged
merged 12 commits into from
Oct 23, 2024
Merged

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Oct 22, 2024

What problem does this PR solve?

Issue Number: close #11679

What is changed and how it works?

Add an integration test for safe mode.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1439%. Comparing base (76ebb37) to head (b0ce002).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6048% <ø> (-0.0135%) ⬇️
dm 50.0616% <ø> (-0.0097%) ⬇️
engine 53.2223% <ø> (+0.0225%) ⬆️
Flag Coverage Δ
unit 55.1439% <ø> (-0.0074%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11678        +/-   ##
================================================
- Coverage   55.1512%   55.1439%   -0.0074%     
================================================
  Files          1001       1001                
  Lines        136472     136472                
================================================
- Hits          75266      75256        -10     
- Misses        55694      55705        +11     
+ Partials       5512       5511         -1     

@lidezhu
Copy link
Collaborator Author

lidezhu commented Oct 23, 2024

/test cdc-integration-pulsar-test

@lidezhu lidezhu changed the title *: add integration test for safe mode *(ticdc): add integration test for safe mode Oct 23, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-23 06:10:14.847972603 +0000 UTC m=+417815.544763206: ☑️ agreed by asddongmen.
  • 2024-10-23 06:47:30.018607727 +0000 UTC m=+420050.715398355: ☑️ agreed by wk989898.

@ti-chi-bot ti-chi-bot bot merged commit ade045e into master Oct 23, 2024
28 checks passed
@ti-chi-bot ti-chi-bot bot deleted the add-safemode-test branch October 23, 2024 06:52
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11682.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11683.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11684.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11685.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Oct 23, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Oct 23, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Oct 23, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ticdc: add a integration test for safe mode
4 participants