-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: add retry for dm-worker to join dm-master #11701
Conversation
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11701 +/- ##
================================================
+ Coverage 55.1556% 55.1635% +0.0079%
================================================
Files 1001 1001
Lines 136481 136485 +4
================================================
+ Hits 75277 75290 +13
+ Misses 55697 55690 -7
+ Partials 5507 5505 -2 |
@@ -31,6 +31,8 @@ import ( | |||
"google.golang.org/grpc/credentials" | |||
) | |||
|
|||
const retryTimes = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is retry interval wait a while between two tries.
if conn != nil { | ||
conn.Close() | ||
// retry to connect master | ||
for i := 0; i < retryTimes; i++ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the comments at line 58
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
ref pingcap/tiup#2464 (comment)
Issue Number: close #4287
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note