Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler(ticdc): fix span loss bug when split regions #11715

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Nov 5, 2024

What problem does this PR solve?

Issue Number: close #11675

What is changed and how it works?

Some regions may not append to spans because of incorrect condition judgment of restSpans.
Make sure all regions are added to the spans before returning.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 5, 2024
@wk989898 wk989898 requested a review from sdojjy November 6, 2024 02:05
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-05 09:40:02.603179609 +0000 UTC m=+947515.442335156: ☑️ agreed by asddongmen.
  • 2024-11-06 02:36:43.743218245 +0000 UTC m=+1008516.582373815: ☑️ agreed by CharlesCheung96.

Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 6, 2024

/retest

@asddongmen asddongmen added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Nov 6, 2024
@asddongmen asddongmen added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 17.24138% with 24 lines in your changes missing coverage. Please review.

Project coverage is 55.1566%. Comparing base (0510cf0) to head (9f08887).
Report is 3 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6044% <17.2413%> (-0.0089%) ⬇️
dm 50.0904% <ø> (+0.0018%) ⬆️
engine 53.2336% <ø> (+0.0282%) ⬆️
Flag Coverage Δ
unit 55.1566% <17.2413%> (+0.0003%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11715        +/-   ##
================================================
+ Coverage   55.1562%   55.1566%   +0.0003%     
================================================
  Files          1001       1001                
  Lines        136485     136524        +39     
================================================
+ Hits          75280      75302        +22     
- Misses        55695      55714        +19     
+ Partials       5510       5508         -2     

@ti-chi-bot ti-chi-bot bot merged commit 1da37a2 into pingcap:master Nov 6, 2024
28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11721.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11722.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11723.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #11724.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11725.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants