dm: fix binlog 999999 test #11726

River2000i · 2024-11-06T05:55:55Z

What problem does this PR solve?

Issue Number: close #4287

What is changed and how it works?

Check List

Tests

Unit test
Integration test
pass https://github.com/pingcap/tiflow/actions/runs/12004028356/job/33458364347
Manual test (add detailed scripts or steps below)
No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

sre-bot · 2024-11-06T05:56:02Z

All committers have signed the CLA.

ti-chi-bot · 2024-11-06T05:56:04Z

Welcome @River2000i!

It looks like this is your first PR to pingcap/tiflow 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/tiflow. 😃

ti-chi-bot · 2024-11-06T05:56:04Z

Hi @River2000i. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

River2000i · 2024-11-25T05:41:34Z

.github/workflows/dm_binlog_999999.yaml

+          echo "show binary logs;" | mysql -uroot -h127.0.0.1 -P3306 -p123456 | grep -q "mysql-bin.1000003"
+          echo "show binary logs;" | mysql -uroot -h127.0.0.1 -P3307 -p123456 | grep -q "mysql-bin.1000002"


Mysql 3306 trigger 4 times flush logs in case and restart 1 time. Mysql 3307 trigger 3 times flush logs in case and restart 1 time. The origin binlog file is mysql-bin.999998.

River2000i · 2024-11-25T05:58:55Z

.github/workflows/dm_binlog_999999.yaml

+          echo "show binary logs;" | mysql -uroot -h127.0.0.1 -P3306 -p123456
+          echo "show binary logs;" | mysql -uroot -h127.0.0.1 -P3307 -p123456


wait mysql Warning: arning] Using a password on the command line interface can be insecure. Log_name File_size mysql-bin.999998 177 mysql-bin.999999 1[54](https://github.com/pingcap/tiflow/actions/runs/12004028356/job/33458364347#step:12:55) Warning: arning] Using a password on the command line interface can be insecure. Log_name File_size Encrypted mysql-bin.999998 179 No mysql-bin.999999 1[56](https://github.com/pingcap/tiflow/actions/runs/12004028356/job/33458364347#step:12:57) No

D3Hunter · 2024-11-25T06:06:27Z

.github/workflows/dm_binlog_999999.yaml

+          msg_type: text
+          content: |
+            text: |
+              dataflow engine chaos job failed, see https://github.com/pingcap/tiflow/actions/runs/${{ github.run_id }}


Suggested change

dataflow engine chaos job failed, see https://github.com/pingcap/tiflow/actions/runs/${{ github.run_id }}

DM chaos job failed, see https://github.com/pingcap/tiflow/actions/runs/${{ github.run_id }}

lance6716

please address existing comment

ti-chi-bot · 2024-11-25T06:15:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-11-25T06:15:15Z

[LGTM Timeline notifier]

Timeline:

2024-11-25 06:10:43.523436989 +0000 UTC m=+444031.143091505: ☑️ agreed by lance6716.
2024-11-25 06:15:14.826209813 +0000 UTC m=+444302.445864328: ☑️ agreed by D3Hunter.

River2000i · 2024-11-25T07:13:11Z

/retest

ti-chi-bot · 2024-11-25T07:13:26Z

@River2000i: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

River2000i · 2024-11-26T04:23:21Z

/retest

install tool by apt-get

7bcb187

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 6, 2024

ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Nov 6, 2024

ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2024

GMHDBJD added the component/test Unit tests and integration tests component. label Nov 6, 2024

use sudo

1c510b9

River2000i closed this Nov 6, 2024

River2000i reopened this Nov 6, 2024

River2000i added 2 commits November 6, 2024 14:38

trigger test

d073514

use sudo

1b6b7e9

River2000i closed this Nov 6, 2024

River2000i reopened this Nov 6, 2024

setup docker

ecb9465

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2024

River2000i added 6 commits November 15, 2024 16:31

fix

36e8d02

fix

35bb830

fix

cee651e

debug

5270aa1

f

8be5212

fix

e5c2b7f

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2024

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2024

River2000i added 2 commits November 25, 2024 12:39

fix

54d15d9

f

36e25d2

ti-chi-bot bot added the area/dm Issues or PRs related to DM. label Nov 25, 2024

River2000i added 2 commits November 25, 2024 13:24

f

2816e20

fix

b3cc645

River2000i commented Nov 25, 2024

View reviewed changes

River2000i added 2 commits November 25, 2024 13:42

f

8a601d7

f

d316863

River2000i changed the title ~~[WIP]dm: fix binlog 999999 test~~ dm: fix binlog 999999 test Nov 25, 2024

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024

River2000i commented Nov 25, 2024

View reviewed changes

D3Hunter reviewed Nov 25, 2024

View reviewed changes

lance6716 approved these changes Nov 25, 2024

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 25, 2024

address comment

5ea5127

D3Hunter approved these changes Nov 25, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024

GMHDBJD added the ok-to-test Indicates a PR is ready to be tested. label Nov 25, 2024

ti-chi-bot bot removed the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Nov 26, 2024

ti-chi-bot bot merged commit 3cbc91d into pingcap:master Nov 26, 2024
26 checks passed

River2000i deleted the fix-binlog_999999 branch November 26, 2024 06:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dm: fix binlog 999999 test #11726

dm: fix binlog 999999 test #11726

River2000i commented Nov 6, 2024 •

edited

Loading

sre-bot commented Nov 6, 2024 •

edited

Loading

ti-chi-bot bot commented Nov 6, 2024

ti-chi-bot bot commented Nov 6, 2024

River2000i Nov 25, 2024 •

edited

Loading

River2000i Nov 25, 2024

D3Hunter Nov 25, 2024

River2000i Nov 25, 2024

lance6716 left a comment

ti-chi-bot bot commented Nov 25, 2024

ti-chi-bot bot commented Nov 25, 2024

River2000i commented Nov 25, 2024

ti-chi-bot bot commented Nov 25, 2024

River2000i commented Nov 26, 2024

		echo "show binary logs;" \| mysql -uroot -h127.0.0.1 -P3306 -p123456 \| grep -q "mysql-bin.1000003"
		echo "show binary logs;" \| mysql -uroot -h127.0.0.1 -P3307 -p123456 \| grep -q "mysql-bin.1000002"

	dataflow engine chaos job failed, see https://github.com/pingcap/tiflow/actions/runs/${{ github.run_id }}
	DM chaos job failed, see https://github.com/pingcap/tiflow/actions/runs/${{ github.run_id }}

dm: fix binlog 999999 test #11726

dm: fix binlog 999999 test #11726

Conversation

River2000i commented Nov 6, 2024 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

sre-bot commented Nov 6, 2024 • edited Loading

ti-chi-bot bot commented Nov 6, 2024

ti-chi-bot bot commented Nov 6, 2024

River2000i Nov 25, 2024 • edited Loading

Choose a reason for hiding this comment

River2000i Nov 25, 2024

Choose a reason for hiding this comment

D3Hunter Nov 25, 2024

Choose a reason for hiding this comment

River2000i Nov 25, 2024

Choose a reason for hiding this comment

lance6716 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Nov 25, 2024

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

River2000i commented Nov 25, 2024

ti-chi-bot bot commented Nov 25, 2024

River2000i commented Nov 26, 2024

River2000i commented Nov 6, 2024 •

edited

Loading

sre-bot commented Nov 6, 2024 •

edited

Loading

River2000i Nov 25, 2024 •

edited

Loading