-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puller: fix retry logic when check store version failed #11903
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11903 +/- ##
================================================
+ Coverage 55.1686% 55.1700% +0.0013%
================================================
Files 1003 1003
Lines 137493 137504 +11
================================================
+ Hits 75853 75861 +8
- Misses 56092 56094 +2
- Partials 5548 5549 +1 |
/retest |
1 similar comment
/retest |
} | ||
} | ||
|
||
func (s *requestedStream) run(ctx context.Context, c *SharedClient, rs *requestedStore) error { | ||
if err := version.CheckStoreVersion(ctx, c.pd, rs.storeID); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we just need to move CheckStoreVersion
out from run
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change requestedStream.run
from return bool
to return error
enable us to handle more kinds of error in the future.
And what's the benefits of move CheckStoreVersion
out from run?
Below is my understanding of how this PR works. Please correct me if I am wrong. Initial Problem:
Fix:
|
What problem does this PR solve?
Issue Number: close #11766
What is changed and how it works?
Change the retry logic to reload region when
client.GetStore
failed.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note