owner: wait all task metadata cleaned before creating new changefeed (#1212) #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
LGTM |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/merge |
amyangfei
approved these changes
Dec 16, 2020
ti-srebot
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1212 to release-4.0
What problem does this PR solve?
Fix https://github.com/pingcap/ticdc/issues/1211
Root cause: There exists race condition when CDC owner creates a new changefeed (which will assign new task status) and a stale processor stops (which is responsible for replicating the same changefeed). The latest task status written by owner could be deleted by a stale processor.
What is changed and how it works?
This PR changes the update of
task statusto a linearizable way, which means a paused/removed task status can be deleted, but cannot be put.TODO: We should summary the schedule model of CDC owner and processor to make it works in a provable automaton.
Check List
Tests
Release note