capture: fix incorrect session aliveness detection (#1237) #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
2 tasks
ti-srebot
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## release-4.0-pending #1240 +/- ##
===========================================================
+ Coverage 45.9675% 46.2544% +0.2869%
===========================================================
Files 112 112
Lines 11767 11774 +7
===========================================================
+ Hits 5409 5446 +37
+ Misses 5747 5711 -36
- Partials 611 617 +6 |
amyangfei
approved these changes
Dec 29, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
amyangfei
pushed a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1237 to release-4.0
What problem does this PR solve?
Fix https://github.com/pingcap/ticdc/issues/1234
What is changed and how it works?
This is part 1 of #1234
Check List
Tests
Release note