-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner: check update safepoint error (#1282) #1367
Merged
ti-srebot
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-9817ce8f1099
Jan 28, 2021
Merged
owner: check update safepoint error (#1282) #1367
ti-srebot
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-9817ce8f1099
Jan 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
type/bugfix
This PR fixes a bug.
component/replica-model
Replication model component.
status/ptal
Could you please take a look?
type/4.0-cherry-pick
labels
Jan 28, 2021
LGTM |
zier-one
approved these changes
Jan 28, 2021
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jan 28, 2021
LGTM |
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jan 28, 2021
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1367 +/- ##
================================================
Coverage ? 47.9520%
================================================
Files ? 130
Lines ? 13184
Branches ? 0
================================================
Hits ? 6322
Misses ? 6181
Partials ? 681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/replica-model
Replication model component.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
status/ptal
Could you please take a look?
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1282 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In ticdc repo: git pr https://github.com/pingcap/ticdc/pull/1367
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Related changes
Release note