kv-client: fix stream is not recycled when meeting recv error (#1336) #1373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1336 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In ticdc repo: git pr https://github.com/pingcap/ticdc/pull/1373
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
stream.Recv
with error, but the underlying stream is normal actually (or the next round ofstream.Send
is successfully, then thereceiveFromStream
goroutine will be never created, and corresponding events will not be consumed by kv client.What is changed and how it works?
receiveFromStream
routine exits, and remove stream from stream cacheCheck List
Tests
Release note