kv-client: use multiple sync.Map to reduce lock contention #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
status/WIP
component/kv-client
|
/run-all-tests |
amyangfei
force-pushed
the
kv-client-reduce-goroutine-map-optimization
branch
2 times, most recently
from
7035d36 to
c9ec547
Compare
|
/run-all-tests |
This was referenced Feb 24, 2021
Closed
amyangfei
force-pushed
the
kv-client-reduce-goroutine-map-optimization
branch
from
c9ec547 to
c6fb15e
Compare
amyangfei
added
status/ptal
|
/run-integration-tests |
zier-one
reviewed
Mar 2, 2021
cdc/kv/region_worker_test.go
Outdated
|
|
||
| var wg sync.WaitGroup | ||
| wg.Add(2) | ||
| go func() { |
There was a problem hiding this comment.
could you please add more goroutine to make sure the thread-safety?
|
LGTM |
|
LGTM |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Mar 2, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merge |
|
/run-all-tests |
|
/run-kafka-tests |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Mar 2, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1476 |
ti-srebot
added a commit
that referenced
this pull request
Mar 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part 3 of #1393, please review this PR after #1426 is merged
sync.Mapis faster than RWMutex and Mutex. Note this is concluded from some benchmarks, such as sync: RWMutex scales poorly with CPU count golang/go#17973, https://www.jianshu.com/p/cffffa914381, but maybe not quite suitable for our scene, we need more tests for this point, the most important thing here is to simulate the real world workload.sync.Mapcan accelerate map accessWhat is changed and how it works?
sync.Maps for regionFeedState get/put operation.sync.Mappool is determined by cpu number, min threshold, and max thresholdCheck List
Tests
Release note