Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Should keep retrying singleEventFeed #149

Closed
wants to merge 1 commit into from
Closed

bugfix: Should keep retrying singleEventFeed #149

wants to merge 1 commit into from

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Dec 2, 2019

What problem does this PR solve?

partialRegionFeed should keep retrying singleEventFeed until the region is no longer valid.
So the maxRetries parameter should be set to 0.

What is changed and how it works?

Set maxRetries to be 0.

Check List

Tests

  • Unit test

@suzaku suzaku added the status/ptal Could you please take a look? label Dec 2, 2019
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use a finite retry time. If some API in partialRegionFeed always returns error and context is not canceled by other routines, the loop will not exits then.

@suzaku
Copy link
Contributor Author

suzaku commented Dec 3, 2019

@july2993 What do you think? In your original implementation maxRetries was not set.

@july2993
Copy link
Contributor

july2993 commented Dec 3, 2019

keep use a finite retry time?

@suzaku
Copy link
Contributor Author

suzaku commented Dec 3, 2019

OK

@suzaku suzaku closed this Dec 3, 2019
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
* add kv abstract interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants