Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter: fix error decoding when rowid is very large #153

Merged
merged 2 commits into from
Dec 4, 2019
Merged

mounter: fix error decoding when rowid is very large #153

merged 2 commits into from
Dec 4, 2019

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Dec 3, 2019 •
edited
Loading

What problem does this PR solve?

we can execute this query in the upstream database to recurrent the bug:

CREATE TABLE testDB.large_int(id BIGINT UNSIGNED PRIMARY KEY);
insert into testDB.large_int values (18446744073709551615) # 18446744073709551615 is MaxUint64

the id column is handle, and CDC decode it to -1 mistakenly.

Check List

Tests

  • Unit test

@zier-one zier-one added type/bug The issue is confirmed as a bug. status/ptal Could you please take a look? labels Dec 3, 2019
suzaku
suzaku reviewed Dec 4, 2019
View reviewed changes
cdc/entry/mounter.go Outdated Show resolved Hide resolved
cdc/entry/mounter.go Outdated Show resolved Hide resolved
cdc/entry/mounter.go Show resolved Hide resolved
@suzaku suzaku changed the title mounter: fix error docode when rowid is very large mounter: fix error decoding when rowid is very large Dec 4, 2019
@zier-one
Copy link
Contributor Author

zier-one commented Dec 4, 2019

PTAL again @suzaku

suzaku
suzaku approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku added LGT2 and removed status/ptal Could you please take a look? LGT2 labels Dec 4, 2019
@zier-one zier-one added type/bugfix This PR fixes a bug. and removed type/bug The issue is confirmed as a bug. labels Dec 4, 2019
amyangfei
amyangfei approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT2 and removed LGT1 labels Dec 4, 2019
@amyangfei amyangfei merged commit 1ea3d63 into pingcap:master Dec 4, 2019
@amyangfei amyangfei deleted the fix_large_row_id branch December 4, 2019 06:43
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
@amyangfei
mounter: fix error decoding when rowid is very large (pingcap#153)
b37d264
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
@lance6716
jobmaster: add workerImpl example (pingcap#153)
bdd273b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@suzaku suzaku suzaku approved these changes

Assignees
No one assigned
Labels
type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zier-one @suzaku @amyangfei