Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink: unify the time zone between capture and downstream database automatically #157

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Dec 5, 2019

What problem does this PR solve?

unify the time zone between capture and downstream database automatically

What is changed and how it works?

using UTC TZ to parse time and set the TZ of downstream database UTC

Check List

Tests

  • Unit test

@zier-one zier-one added the status/ptal Could you please take a look? label Dec 5, 2019
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku added LGT1 and removed status/ptal Could you please take a look? labels Dec 5, 2019
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT2 and removed LGT1 labels Dec 5, 2019
@amyangfei amyangfei merged commit 2ca6c62 into pingcap:master Dec 5, 2019
@zier-one zier-one deleted the tz branch December 6, 2019 08:42
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
* feat(metaclient(dataflow)): add etcd kv client implement

close issue pingcap#157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants