-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3: increase defaultBufferChanSize (#1469) #1632
s3: increase defaultBufferChanSize (#1469) #1632
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 72523a5
|
Codecov Report
@@ Coverage Diff @@
## release-5.0 #1632 +/- ##
===================================================
+ Coverage 52.6771% 52.7020% +0.0249%
===================================================
Files 152 152
Lines 16062 16062
===================================================
+ Hits 8461 8465 +4
+ Misses 6700 6696 -4
Partials 901 901 |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #1469 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In ticdc repo: git pr https://github.com/pingcap/ticdc/pull/1632
After apply modifications, you can push your change to this PR via:
fix bug issue #1259 reported temporarily
What problem does this PR solve?
fix bug issue #1259 reported temporarily
What is changed and how it works?
increase the defaultBufferChanSize of s3, avoiding the
l.units[hash].dataChan()
full, and blocking theprocessor.output
output rows.https://github.com/pingcap/ticdc/blob/04e028419387871b80ddc95377751092f03f26ae/cdc/sink/cdclog/utils.go#L164-L170
Check List
Tests
Code changes
Side effects
Related changes
Release note