Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: increase defaultBufferChanSize (#1469) #1632

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 10, 2021

cherry-pick #1469 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In ticdc repo:
git pr https://github.com/pingcap/ticdc/pull/1632

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/ticdc.git pr/1632:release-5.0-462870d2b767

fix bug issue #1259 reported temporarily

What problem does this PR solve?

fix bug issue #1259 reported temporarily

What is changed and how it works?

increase the defaultBufferChanSize of s3, avoiding the l.units[hash].dataChan() full, and blocking the processor.output output rows.
https://github.com/pingcap/ticdc/blob/04e028419387871b80ddc95377751092f03f26ae/cdc/sink/cdclog/utils.go#L164-L170

Check List

Tests

  • No code

Code changes

  • Has persistent data change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • s3 sink: increase the defaultBufferChanSize of logSink to avoid blocking

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/pitr Point-in-time recovery component. status/ptal Could you please take a look? size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Apr 10, 2021
@ti-chi-bot ti-chi-bot requested review from 3pointer and zier-one April 10, 2021 05:47
@ti-srebot ti-srebot requested a review from amyangfei April 10, 2021 05:47
@ti-srebot ti-srebot added this to the v5.0.1 milestone Apr 10, 2021
@ti-srebot ti-srebot self-assigned this Apr 10, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2021
@lance6716
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72523a5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2021
@codecov-io
Copy link

Codecov Report

Merging #1632 (72523a5) into release-5.0 (39c1bd9) will increase coverage by 0.0249%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-5.0      #1632        +/-   ##
===================================================
+ Coverage      52.6771%   52.7020%   +0.0249%     
===================================================
  Files              152        152                
  Lines            16062      16062                
===================================================
+ Hits              8461       8465         +4     
+ Misses            6700       6696         -4     
  Partials           901        901                

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 12, 2021
@ti-chi-bot ti-chi-bot merged commit 7893add into pingcap:release-5.0 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/pitr Point-in-time recovery component. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants