Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorter: cherry-pick Unified Sorter changes to release-4.0 #1730

Merged
merged 5 commits into from
May 8, 2021
Merged

sorter: cherry-pick Unified Sorter changes to release-4.0 #1730

merged 5 commits into from
May 8, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Apr 30, 2021

What problem does this PR solve?

  • Cherry-pick several Unified Sorter changes to release-4.0

What is changed and how it works?

  • Cherry-pick several Unified Sorter changes to release-4.0

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix several Unified Sorter stability issues

@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 30, 2021
@amyangfei
Copy link
Contributor

Please remove the change tests/http_proxies/run.sh → tests/http_proxies/run.sh.skip

@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@amyangfei amyangfei changed the base branch from release-4.0-pending to release-4.0 April 30, 2021 09:30
@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 30, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

7 similar comments
@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Apr 30, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented May 1, 2021

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021 •
edited
Loading

Codecov Report

Merging #1730 (1910768) into release-4.0 (753073a) will increase coverage by 0.1452%.
The diff coverage is 62.7118%.

@@                 Coverage Diff                 @@
##           release-4.0      #1730        +/-   ##
===================================================
+ Coverage      53.7661%   53.9114%   +0.1452%     
===================================================
  Files              153        153                
  Lines            15958      16145       +187     
===================================================
+ Hits              8580       8704       +124     
- Misses            6475       6527        +52     
- Partials           903        914        +11

@liuzix
Copy link
Contributor Author

liuzix commented May 1, 2021

/run-all-tests

@overvenus
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 2, 2021
@liuzix liuzix force-pushed the zixiong-cp-4.0-unified-sorter branch from d3ea0ca to c44f0d9 Compare May 2, 2021 13:57
@liuzix
Copy link
Contributor Author

liuzix commented May 2, 2021

/run-all-tests

3 similar comments
@liuzix
Copy link
Contributor Author

liuzix commented May 5, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented May 5, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented May 5, 2021

/run-all-tests

@amyangfei amyangfei mentioned this pull request May 6, 2021
Closed
@liuzix liuzix force-pushed the zixiong-cp-4.0-unified-sorter branch from d3ea0ca to 2c14bf3 Compare May 6, 2021 08:33
@liuzix
Copy link
Contributor Author

liuzix commented May 6, 2021

/run-all-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c14bf3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2021
@liuzix
Copy link
Contributor Author

liuzix commented May 7, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented May 8, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit fa5d48f into pingcap:release-4.0 May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @amyangfei @codecov-commenter @overvenus @ti-chi-bot @zhouqiang-cl