Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_server: add http handler for failpoint (#1722) #1732

Merged
merged 2 commits into from
May 11, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 1, 2021

cherry-pick #1722 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In ticdc repo:
git pr https://github.com/pingcap/ticdc/pull/1732

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/ticdc.git pr/1732:release-4.0-e4e96ed4204a

What problem does this PR solve?

  • Lack of a convenient way to control failpoints at runtime.

What is changed and how it works?

  • Added an http API endpoint as /fail/

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Aadd http handler for failpoint

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/ptal Could you please take a look? size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/4.0-cherry-pick labels May 1, 2021
@ti-srebot ti-srebot added this to the v4.0.13 milestone May 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #1732 (d0a5483) into release-4.0 (753073a) will increase coverage by 0.0559%.
The diff coverage is 100.0000%.

@@                 Coverage Diff                 @@
##           release-4.0      #1732        +/-   ##
===================================================
+ Coverage      53.7661%   53.8220%   +0.0559%     
===================================================
  Files              153        153                
  Lines            15958      15960         +2     
===================================================
+ Hits              8580       8590        +10     
+ Misses            6475       6468         -7     
+ Partials           903        902         -1     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2021
@zier-one
Copy link
Contributor

zier-one commented May 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • leoppro

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2021
@liuzix
Copy link
Contributor

liuzix commented May 7, 2021

/lgtm

@liuzix
Copy link
Contributor

liuzix commented May 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d0a5483

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-leak-tests

@amyangfei amyangfei added type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. and removed type/4.0-cherry-pick labels May 10, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 11, 2021
@ti-chi-bot ti-chi-bot merged commit dfd4b81 into pingcap:release-4.0 May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants