Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd_worker: fix a bug that etcd worker maybe lost data at starting #1813

Merged
merged 4 commits into from
May 24, 2021
Merged

etcd_worker: fix a bug that etcd worker maybe lost data at starting #1813

merged 4 commits into from
May 24, 2021

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

  • Fix a bug that etcd worker lost data
  • a etcd worker bank test

What is changed and how it works?

the etcd worker have two steps when it's starting:

  1. read entire data snapshot and apply it to the reactor state
  2. start to watch the data change log from etcd and apply logs to the reacator state

the data lost between step 1 and step 2 because the start reversion of the watch is not set

Check List

Tests

  • Unit test

Release note

  • No release note

@zier-one zier-one added the status/ptal Could you please take a look? label May 20, 2021
@zier-one zier-one added the needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. label May 20, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2021
@zier-one zier-one added the needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. label May 20, 2021
@ben1009
Copy link
Contributor

ben1009 commented May 21, 2021

/ l g t m

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 21, 2021
lichunzhu
lichunzhu reviewed May 21, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 21, 2021
@zier-one
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5123cd7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 21, 2021
@zier-one
Copy link
Contributor Author

/rebuild

@zier-one
Copy link
Contributor Author

/run-all-tests

@zier-one
Copy link
Contributor Author

/run-kafka-tests

2 similar comments
@amyangfei
Copy link
Contributor

/run-kafka-tests

@zier-one
Copy link
Contributor Author

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 99ee8fb into pingcap:master May 24, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 24, 2021
@ti-chi-bot
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
82039ec 
…ingcap#1813)
@ti-chi-bot ti-chi-bot mentioned this pull request May 24, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1822.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 24, 2021
@ti-chi-bot
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
725af32 
…ingcap#1813)
@ti-chi-bot ti-chi-bot mentioned this pull request May 24, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1823.

zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 17, 2021
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
b371b2c 
…ingcap#1813)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
d98305e 
…ingcap#1813)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
3acbe12 
…ingcap#1813)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
11ec9b6 
…ingcap#1813)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
a0df868 
…ingcap#1813)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
3cca96f 
…ingcap#1813)
ti-chi-bot pushed a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
etcd_worker: fix a bug that etcd worker maybe lost data at starting (#…
de83d16 
…1813)
ti-chi-bot pushed a commit that referenced this pull request Jun 23, 2021
@ti-chi-bot
etcd_worker: fix a bug that etcd worker maybe lost data at starting (#…
94190b3 
…1813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@amyangfei amyangfei amyangfei approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zier-one @ben1009 @ti-chi-bot @amyangfei @lichunzhu