Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add metrics for table memory consumption #1846

Merged
merged 12 commits into from
May 31, 2021
Merged

metrics: add metrics for table memory consumption #1846

merged 12 commits into from
May 31, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented May 26, 2021

What problem does this PR solve?

  • Lack of observability of processor's table memory consumption (down from the sorter)

What is changed and how it works?

  • Added two Grafana panels for metrics added for flow control.

Check List

Tests

  • Manual test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

  • Add metrics for table memory consumption

@liuzix liuzix added status/ptal Could you please take a look? needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. component/metrics-logging Metrics and logging component. labels May 26, 2021
@liuzix liuzix added this to the v5.0.2 milestone May 26, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 26, 2021
@overvenus
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 516b25f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2021
@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2021

/merge

2 similar comments
@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2021

/merge

@liuzix
Copy link
Contributor Author

liuzix commented May 27, 2021

/merge

@liuzix
Copy link
Contributor Author

liuzix commented May 27, 2021

/merge

@liuzix
Copy link
Contributor Author

liuzix commented May 28, 2021

/merge

@amyangfei
Copy link
Contributor

/merge

@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #1846 (71d99ab) into master (99ee8fb) will increase coverage by 0.7492%.
The diff coverage is 69.7029%.

@@               Coverage Diff                @@
##             master      #1846        +/-   ##
================================================
+ Coverage   53.4083%   54.1576%   +0.7492%     
================================================
  Files           154        159         +5     
  Lines         16166      16644       +478     
================================================
+ Hits           8634       9014       +380     
- Misses         6608       6668        +60     
- Partials        924        962        +38

@ti-chi-bot ti-chi-bot merged commit ca64c78 into pingcap:master May 31, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1884.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 31, 2021
@liuzix @ti-chi-bot
This is an automated cherry-pick of pingcap#1846
e2b88b5 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced May 31, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1885.

ti-chi-bot added a commit that referenced this pull request May 31, 2021
@ti-chi-bot
metrics: add metrics for table memory consumption (#1846) (#1885)
75fb304
ti-chi-bot added a commit that referenced this pull request Jun 24, 2021
@ti-chi-bot
metrics: add metrics for table memory consumption (#1846) (#1884)
2f5de76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
component/metrics-logging Metrics and logging component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
5 participants
@liuzix @overvenus @ti-chi-bot @amyangfei @codecov-commenter